Hi,
On Wed, 9 Jun 2021 at 01:05, Thomas Rodgers via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > Tested x86_64-pc-linux-gnu, committed to master, backported to > releases/gcc-11. > > On Tue, Jun 8, 2021 at 8:44 AM Jonathan Wakely <jwak...@redhat.com> wrote: > > > On Tue, 8 Jun 2021 at 01:29, Thomas Rodgers wrote: > > > >> This time without the repeatred [PRnnnn] in the subject line. > >> > >> Fixes libstdc++/100889 > >> > > > > This should be part of the ChangeLog entry instead, preceded by PR so it > > updates bugzilla, i.e. > > > > > > > >> libstdc++-v3/ChangeLog: > >> > > > > <TAB>PR libstdc++/100889 > > > > > >> * include/bits/atomic_base.h (atomic_ref<_Tp*>::wait): > >> Change parameter type from _Tp to _Tp*. > >> * testsuite/29_atomics/atomic_ref/wait_notify.cc: Extend > >> coverage of types tested. > >> > > > > > > OK for trunk and gcc-11 with that change, thanks. > > > > This is causing a regression on old arm targets: --target arm-none-linux-gnueabi RUNTESTFLAGS: -march=armv5t FAIL: 29_atomics/atomic_ref/wait_notify.cc (test for excess errors) Excess errors: /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: /ccaaHfBz.o: in function `void std::__atomic_impl::store<double>(double*, std::remove_volatile<double>::type, std::memory_order)': /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:971: undefined reference to `__atomic_store_8' /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: /ccaaHfBz.o: in function `std::remove_volatile<double>::type std::__atomic_impl::load<double>(double const*, std::memory_order)': /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:979: undefined reference to `__atomic_load_8' /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:979: undefined reference to `__atomic_load_8' /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:979: undefined reference to `__atomic_load_8' collect2: error: ld returned 1 exit status Can you check? Thanks
