On Thu, 10 Jun 2021, Jakub Jelinek wrote: > On Wed, Jun 09, 2021 at 12:08:39PM -0700, sunil.k.pandey via Gcc-patches > wrote: > > On Linux/x86_64, > > > > 374f93da97fb0378453d503f3cfea4d7a923a89c is the first bad commit > > commit 374f93da97fb0378453d503f3cfea4d7a923a89c > > Author: Richard Biener <rguent...@suse.de> > > Date: Wed Jun 9 14:48:35 2021 +0200 > > > > tree-optimization/100981 - fix SLP patterns involving reductions > > > > caused > > > > FAIL: libgomp.fortran/pr100981-2.f90 -O0 execution test > > FAIL: libgomp.fortran/pr100981-2.f90 -O1 execution test > > FAIL: libgomp.fortran/pr100981-2.f90 -O2 execution test > > FAIL: libgomp.fortran/pr100981-2.f90 -O3 -g execution test > > FAIL: libgomp.fortran/pr100981-2.f90 -Os execution test > > Aren't the dsdotr and dsdoti variables uninitialized? > Shouldn't they be initialized to zero? > > Following fixes it for me on i686-linux, but I haven't checked if it > fails with the patch reverted.
whoops yes. Strange my testing didn't trip (and in a just built tree the testcases do not fail for me - "bad" luck I guess). Thanks for fixing. Richard. > 2021-06-10 Jakub Jelinek <ja...@redhat.com> > > * testsuite/libgomp.fortran/pr100981-2.f90 (cdcdot): Initialize > dsdotr and dsdoti to 0. > > --- libgomp/testsuite/libgomp.fortran/pr100981-2.f90.jj 2021-06-09 > 22:51:44.548834216 +0200 > +++ libgomp/testsuite/libgomp.fortran/pr100981-2.f90 2021-06-10 > 01:08:18.056464950 +0200 > @@ -9,6 +9,8 @@ complex function cdcdot(n, cx) > double precision :: dsdotr, dsdoti, dt1, dt3 > > kx = 1 > + dsdotr = 0 > + dsdoti = 0 > do i = 1, n > dt1 = real(cx(kx)) > dt3 = aimag(cx(kx)) > > > Jakub > > -- Richard Biener <rguent...@suse.de> SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)
