On Mon, Jun 21, 2021 at 11:55 PM Martin Sebor via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/571980.html > > Looking for a review of the LTO changes to switch TREE_NO_WARNING to > the suppress_warning() API.
Hmm, since the warning suppressions are on location ad-hoc data the appropriate thing is to adjust the location streaming and that part seems to be missing? So what you now stream is simply the "everything" fallback, correct? In particular: else - bp_pack_value (bp, TREE_NO_WARNING (expr), 1); + /* FIXME: pack all warning bits. */ + bp_pack_value (bp, warning_suppressed_p (expr), 1); this looks like a wrong comment in that light. - else - compare_values (TREE_NO_WARNING); + else if (t1->base.nowarning_flag != t2->base.nowarning_flag) + return false; uh. Can you keep sth like TREE_NO_WARNING_RAW or so? Thanks, Richard. > On 6/4/21 3:43 PM, Martin Sebor wrote: > > The attached patch replaces the uses of TREE_NO_WARNING in the LTO > > front end with the new suppress_warning() API. It adds a couple of > > FIXMEs that I plan to take care of in a follow up. >
