On 7/9/21 7:26 AM, Rainer Orth wrote:
Hi Martin,
Yesterday's enhancement to -Warray-bounds has exposed a couple of
issues in libgo where the code writes into an invalid constant
address that the warning is designed to flag.
On the assumption that those invalid addresses are deliberate,
the attached patch suppresses these instances by using #pragma
GCC diagnostic but I don't think I'm supposed to commit it (at
least Git won't let me). To avoid Go bootstrap failures please
either apply the patch or otherwise suppress the warning (e.g.,
by using a volatile pointer temporary).
while this patch does fix the libgo bootstrap failure, Go is completely
broken: almost 1000 go.test failures and all libgo tests FAIL as well.
Seen on both i386-pc-solaris2.11 and sparc-sun-solaris2.11.
FWIW, I see exactly the same failures on x86_64-pc-linux-gnu, so nothing
Solaris-specific here.
I don't normally test Go because of PR 91992, but I see just
the three test failures below on x86_64-linux with the latest trunk:
FAIL: go.test/test/fixedbugs/issue10441.go -O (test for excess errors)
FAIL: ./index0-out.go execution, -O0 -g -fno-var-tracking-assignments
FAIL: runtime/pprof
The excess errors don't look related to my changes:
FAIL: go.test/test/fixedbugs/issue10441.go -O (test for excess errors)
Excess errors:
/usr/bin/ld:
/ssd/test/build/gcc-trunk/x86_64-pc-linux-gnu/./libgo/.libs/libgo.so:
undefined reference to `__go_init_main'
/usr/bin/ld:
/ssd/test/build/gcc-trunk/x86_64-pc-linux-gnu/./libgo/.libs/libgo.so:
undefined reference to `main.main'
My libgo.log shows the FAILs below. I don't know how to interpret
that but nothing in the file suggests that my change is the cause
of these failures
--- FAIL: ExampleFrames (0.00s)
FAIL
FAIL: runtime
--- FAIL: TestConvertCPUProfile (0.00s)
--- FAIL: TestConvertMemProfile (0.00s)
--- FAIL: TestConvertMemProfile/heap (0.00s)
--- FAIL: TestConvertMemProfile/allocs (0.00s)
FAIL
FAIL: runtime/pprof
--- FAIL: ExampleFrames (0.00s)
FAIL
FAIL: runtime
--- FAIL: TestDurationSeconds (0.00s)
--- FAIL: ExampleParseDuration (0.00s)
FAIL
FAIL: time
If you see different failures in your build that look like they
might be caused by them then please show what those are.
Martin
