Hi! On Thu, Jun 17, 2021 at 10:18:49AM -0500, Bill Schmidt wrote: > * config/rs6000/rs6000-gen-builtins.c (consume_whitespace): New > function. > (advance_line): Likewise. > (safe_inc_pos): Likewise. > (match_identifier): Likewise. > (match_integer): Likewise. > (match_to_right_bracket): Likewise.
> +/* Pass over unprintable characters and whitespace (other than a newline, > + which terminates the scan). */ See Will's review :-) > + buf[lastpos - startpos + 1] = '\0'; Just "= 0"? It means exactly the same. You can write just diag ("bla bla bla") instead of (*diag) ("bla bla bla"); btw. The patch is okay for trunk with whatever you want to do with those comments (but do fix the consume_whitespace comment please). Thanks! Segher