Richard Earnshaw via Gcc-patches <gcc-patches@gcc.gnu.org> writes: > On 14/12/2020 11:29, Andrea Corallo via Gcc-patches wrote: >> Hi all, >> >> I've committed the attached patch as obvious. >> >> This is to set `fill-column' to 80 in c-mode (Emacs default it to 70) so >> now M-q does the right thing. I think is very handy especially in >> comments. >> >> Question: should we update the copyright manually for this file or have >> it updated by 'update-copyright.py'? I think this is not scanning the >> root of the repo. >> >> Thanks >> >> Andrea >> > > Sorry for the very late reply to this, but I've only just tracked it > down as the cause of why emacs had suddenly started to produce lines > that were displaying with a line wrap (I'd add an image, but the mailing > list would likely only strip it off). > > The problem is that this allows a character to appear in column 80 and > emacs then automatically inserts a blank line after it (when the window > is 80 columns wide), which really messes up the formatting. > > The wiki seems to suggest https://gcc.gnu.org/wiki/FormattingCodeForGCC > that the line length should be 79 columns (see the textwidth setting); > although that is not what is set contrib/vimrc. > > Would anyone object if we reduced this by 1 (to 79) in both places?
Sounds good to me FWIW. (Having hit the same issue.) Richard
