On 7/23/21 8:14 AM, Sebastian Huber wrote:
On 23/07/2021 07:31, Martin Liška wrote:
  write_topn_counters (const struct gcov_ctr_info *ci_ptr,
               unsigned t_ix,
-             gcov_unsigned_t n_counts)
+             gcov_unsigned_t n_counts,
+             void (*dump) (const void *, unsigned, void *),
+             void *(*allocate)(unsigned, void *),
+             void *arg)

I would likely prefer dump_fn and allocate_fn argumen t names.

If I use dump_fn and allocate_fn throughout the code, then several lines would 
exceed 79 characters.  This needs more vertical space. Should I still add the 
_fn postfix?


Yes, please do so.

Martin

Reply via email to