On Wed, Jul 28, 2021 at 05:16:32PM -0500, Segher Boessenkool wrote: > On Fri, Jul 16, 2021 at 08:50:20AM -0500, Paul A. Clarke wrote: > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/powerpc/sse4_1-round.h > > @@ -0,0 +1,27 @@ > > +#include <fenv.h> > > +#include <smmintrin.h> > > +#include "sse4_1-check.h" > > + > > +#define DIM(a) (sizeof (a) / sizeof ((a)[0])) > > Pet peeve: sizeof is an operator, not a function, so even if you want to > protect the macro parameter this just is > #define DIM(a) (sizeof (a) / sizeof (a)[0]) > > > + (void) fesetround (round_save); > > Please don't cast to (void). That never does *anything*. > > Okay for trunk (these are all testsuite files after all, and we should > test horrrible style as well! :-P )
I didn't want to be responsible for promulgating horrible style, so I incorporated the above changes and pushed as d656a3d3ce88d402a14e8c120f1b0e78a3979deb. :-) PC
