On Tue, Aug 3, 2021 at 5:40 PM Richard Earnshaw < richard.earns...@foss.arm.com> wrote:
> > > On 03/08/2021 16:04, Christophe Lyon via Gcc-patches wrote: > > On Mon, Aug 2, 2021 at 4:57 PM Richard Earnshaw <rearn...@arm.com> > wrote: > > > >> This patch series addresses an issue that has come to light due to a > >> change in the way GAS handles .fpu directives in the assembler. A fix > >> to the assembler made in binutils 2.34 to clear out all features > >> realated to the FPU when .fpu is emitted has started causing problems > >> for GCC because of the order in which we emit .fpu and .arch_extension > >> directives. To fully address this we need to re-organize the way in > >> which the compiler does this. > >> > >> I'll hold of pushing the patches for a couple of days. Although I've > >> gone through the testsuite quite carefully and run this through > >> several configurations, it's possible that this may have some impact > >> on the testsuite that I've missed. Christophe, is the any chance you > >> can run this through your test environment before I commit this? > >> > >> > > Sorry for the delay, still unpacking emails after hollidays. > > > > Yes I can run the validation for these patches. I think you mean with > all 3 > > patches combined, not 3 validations (patch 1, patches 1+2, patches 1-3) ? > > Yes, the first two are trivial changes that just support the interesting > one, which is the final patch. > > Hi Richard, There are a few regressions with these 3 patches applied, see: https://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/r12-2683-g4d17ca1bc74109e5cc4ef34890b6293c4bcb1d6a-PR101723.patch/report-build-info.html The cortex-m55-nofp-* failures reported in several configs are not actual regressions, it seems: they were already failing, but with a different scan-assembler string, so they are considered different tests. I think I sent patches for these unresolved cortex-m55-nofp-* testcases several weeks/months ago, but I'd have to check. There are regressions when configured --with-cpu cortex-a5 --with-fpu vfpv3-d16-fp16 as well as on armeb. Thanks, Christophe R. > > > > Thanks, > > > > Christophe > > > > > >> R. > >> > >> Richard Earnshaw (3): > >> arm: ensure the arch_name is always set for the build target > >> arm: Don't reconfigure globals in arm_configure_build_target > >> arm: reorder assembler architecture directives [PR101723] > >> > >> gcc/config/arm/arm-c.c | 1 + > >> gcc/config/arm/arm-cpus.in | 1 + > >> gcc/config/arm/arm.c | 190 ++++++++---------- > >> gcc/testsuite/gcc.target/arm/attr-neon.c | 9 +- > >> gcc/testsuite/gcc.target/arm/attr-neon2.c | 35 +++- > >> gcc/testsuite/gcc.target/arm/attr-neon3.c | 43 +++- > >> .../arm/cortex-m55-nofp-flag-hard.c | 2 +- > >> .../arm/cortex-m55-nofp-flag-softfp.c | 2 +- > >> .../arm/cortex-m55-nofp-nomve-flag-softfp.c | 2 +- > >> .../gcc.target/arm/mve/intrinsics/mve_fpu1.c | 5 +- > >> .../gcc.target/arm/mve/intrinsics/mve_fpu2.c | 5 +- > >> gcc/testsuite/gcc.target/arm/pr98636.c | 3 +- > >> 12 files changed, 153 insertions(+), 145 deletions(-) > >> > >> -- > >> 2.25.1 > >> > >> >
