> I think the patch makes sense but the comment says > > Java requires that we elaborated nodes in source order. That > means we must gimplify the inner expression followed by each of > the indices, in order. But we can't gimplify the inner > expression until we deal with any variable bounds, sizes, or > positions in order to deal with PLACEHOLDER_EXPRs. > > and I don't really understand that (not to say Java is no longer supported > by GCC, but Ada does use PLACEHOLDER_EXPRs). In fact the comment > suggests that we _should_ gimplify the inner expression first ... at least > it seems to after your explanations ;)
We already gimplify the inner expression first, i.e. before indices and operands, but we gimplify the "annotations" (special operands) before. > Eric - do you know anything about this? If the comment is right, then Martin's patch should break Ada indeed. -- Eric Botcazou
