Hi,

Although the cctools assembler is based of GNU GAS, it is from a
very old version (1.38) which does not support many of the features
that the target supports test is expecting***.

tested on i686 and x86_64 darwin versions using the cctools as.
OK for master?

thanks
Iain

*** I guess we could be more clever and parse the output to find a version
and then alter the supports condition to “gas NN”, but I don’t currently
have cycles to implement that.


gcc/testsuite/ChangeLog:

        * lib/target-supports.exp: Exclude cctools assembler based on
        GAS 1.38.
---
 gcc/testsuite/lib/target-supports.exp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/lib/target-supports.exp 
b/gcc/testsuite/lib/target-supports.exp
index 44465b14b06..ac9daee26b8 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -9454,7 +9454,14 @@ proc check_effective_target_gas { } {
        set status [remote_exec host "$gcc_as" "-v /dev/null"]
        set as_output [lindex $status 1]
        if { [ string first "GNU" $as_output ] >= 0 } {
-           set use_gas_saved 1
+           # Some Darwin versions have an assembler which is based on an old
+           # version of GAS (and reports GNU assembler in its -v output) but
+           # but doesn't support many of the modern GAS features.
+           if { [ string first "cctools" $as_output ] >= 0 } {
+               set use_gas_saved 0
+           } else {
+               set use_gas_saved 1
+           }
        } else {
            set use_gas_saved 0
        }
-- 
2.24.3 (Apple Git-128)


Reply via email to