On Wed, Jul 21, 2021 at 2:28 AM Kito Cheng <kito.ch...@sifive.com> wrote:
> Use TARGET_COMPUTE_MULTILIB to search the multi-lib reuse for > riscv*-*-elf*, > according following rules: > I find the other_cond support a bit confusing. Is this for -mcmodel perhaps? Why not just say that if so? match_score: weigth -> weight riscv_multi_lib_info_t::parse Calls riscv_subset_list::parse twice when path == ".", the call inside the if looks unnecessary. riscv_multilib_lib_check: Can't found -> Can't find riscv_check_other_cond: might got -> might get riscv_compute_multilib: bare-matel -> bare-metal decition -> decision dection -> decision It isn't clear how the loop with the comment "ignore march and mabi option in cond string" can work. It looks like it computes other_cond, but assumes that there is at most one other_cond, and that it is always at the end of the list since otherwise the length won't be computed correctly. But it doesn't check these constraints. Do you have examples showing how this works? And maybe a little better commentary explaining what this loop does to make it easier to understand. It doesn't mention that it computes other_cond for instance. Jim
