Hi Tobias! On 2021-09-21T21:22:44+0200, Tobias Burnus <tob...@codesourcery.com> wrote: > While the previous patch fixed -Wno-missing-include-dirs and sorted > out some inconsistencies with libcpp warnings, it had two issues: > > * Some superfluous warnings were printed, e.g. for > gfortran nonexisting/file.f90 > there was a warning about include path "nonexisting" not existing > and twice the error that the "nonexisting/file.f90" could not be > read. > > * At least as invoked when build GCC or when running the GCC testsuite, > the passed -B -isystem etc. arguments lead to proper but pointless > diagnostic about 'finclude' or other directories not being found, > causing excess-error FAILS and -Werror build fails.
ACK, I too had seen those (with '-cpp' only?), but not yet reported. > While the latter could be fixed by adding -Wno-missing-include-dirs, > it still felt like the wrong approach. ACK, and also for the ones you already had added. ;-) > While the testsuite does run for me, others reported that they do > see missing-include-dirs warnings. Instead of adding a bunch of > -Wno-missing-include-dirs to the test config, I now only warn for > -I and -J by default (similar to previous state) and only do a full > warnings when the user requested passes the -Wmissing-include-dirs > explicitly. The Fortran behavior is now also properly documented > in the manual. ACK, such an approach seems reasonable to me. (But I can't formally approve, of course.) Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
