> ...the subject line for the commit should be the first line of the > commit message, followed by a blank line, followed by the description of > the patch; without the subject line, git format-patch thought your whole > description was the subject of the patch.
oh, I didn't realize this without your mentioning it. I read this guide (https://gcc.gnu.org/codingconventions.html#ChangeLogs) many times and still don't get this. I guess it was written long long ago. > I've corrected this and pushed the patch, thanks! I do thank you and without your help I might never accomplish this task. Once again appreciate your patient help! On Fri, Oct 1, 2021 at 11:46 AM Jason Merrill <ja...@redhat.com> wrote: > > On 10/1/21 11:10, Nick Huang wrote: > >> gcc-verify still fails with this version: > >> > >>> ERR: line should start with a tab: " PR c++/101783" > >>> ERR: line should start with a tab: " * tree.c > >>> (cp_build_qualified_type_real): Excluding typedef from error" > >>> ERR: line should start with a tab: " PR c++/101783" > >>> ERR: line should start with a tab: " * g++.dg/parse/pr101783.C: New > >>> test." > > > >> It might work better to attach the output of git format-patch. > > Sorry for my clumsy copy/paste from git commit message. I now attach > > git format-patch output > > file as attachment. Also maybe for a little convenience of your work, > > I also attach the original > > commit message file when I do git commit -F. > > Thanks, but that isn't necessary; it should be the same in the > format-patch output, except... > > > From e592a475030d99647de736d294cb3c6a7588af49 Mon Sep 17 00:00:00 2001 > > From: qingzhe huang <nickhuan...@hotmail.com> > > Date: Fri, 1 Oct 2021 10:46:35 -0400 > > Subject: [PATCH] The root cause of this bug is that it considers reference > > with cv-qualifiers as an error by generating value for variable > > "bad_quals". > > However, this is not correct for case of typedef. Here I quote spec > > [dcl.ref]/1 : "Cv-qualified references are ill-formed except when the > > cv-qualifiers are introduced through the use of a typedef-name > > ([dcl.typedef], [temp.param]) or decltype-specifier ([dcl.type.decltype]), > > in > > which case the cv-qualifiers are ignored." > > ...the subject line for the commit should be the first line of the > commit message, followed by a blank line, followed by the description of > the patch; without the subject line, git format-patch thought your whole > description was the subject of the patch. > > I've corrected this and pushed the patch, thanks! > > Jason > -- nick huang/qingzhe huang http://www.staroceans.com http://www.staroceans.com/english.htm
