A recent improvement in Waddress causes a bootstrap failure on
targets that define TARGET_FORMAT_TYPES since it cannot be NULL
if defined to an address.

There is no default for this target macro, and it would seem no
purpose to defining it to NULL, so the warning appears reasonable.

Fixed by removing the pointless test.

Tested on x86_64-darwin, pushed to master as a bootstrap fix
The targets that define TARGET_FORMAT_TYPES are Solaris, MinGW
and Darwin, so cc-ing the Solaris and MinGW maintainers.

thanks
Iain

Signed-off-by: Iain Sandoe <i...@sandoe.co.uk>

gcc/c-family/ChangeLog:

        * c-format.c: Remove a test of TARGET_FORMAT_TYPES with
        NULL, this is not needed.
---
 gcc/c-family/c-format.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/c-family/c-format.c b/gcc/c-family/c-format.c
index b4cb765a9d3..ca66c81f716 100644
--- a/gcc/c-family/c-format.c
+++ b/gcc/c-family/c-format.c
@@ -5150,7 +5150,7 @@ handle_format_attribute (tree *node, tree atname, tree 
args,
 #ifdef TARGET_FORMAT_TYPES
   /* If the target provides additional format types, we need to
      add them to FORMAT_TYPES at first use.  */
-  if (TARGET_FORMAT_TYPES != NULL && !dynamic_format_types)
+  if (!dynamic_format_types)
     {
       dynamic_format_types = XNEWVEC (format_kind_info,
                                      n_format_types + TARGET_N_FORMAT_TYPES);
-- 
2.24.3 (Apple Git-128)

Reply via email to