On 2021/10/29 19:52, Richard Biener wrote:
> On Wed, 27 Oct 2021, Xionghu Luo wrote:
>
>> loop_version currently does lv_adjust_loop_entry_edge
>> before it loopifys the copy inserted on the header. This patch moves
>> the condition generation later and thus we have four pieces to help
>> understanding of how the adjustment works:
>> 1) duplicating the loop on the entry edge.
>> 2) loopify the duplicated new loop.
>> 3) adjusting the CFG to insert a condition branching to either loop
>> with lv_adjust_loop_entry_edge.
>> 4) From loopify extract the scale_loop_frequencies bits.
>>
>> Also removed some piece of code seems obviously useless which is not
>> completely sure:
>> - redirect_all_edges since it is false and loopify only called once.
>> - extract_cond_bb_edges and lv_flush_pending_stmts (false_edge) as the
>> edge is not redirected actually.
>
> This is OK (you can also commit this independently), thanks for the
> cleanup.
Thanks, committed this and [PATCH v2 4/4] to r12-4818 and r12-4819.
--
Thanks,
Xionghu