On Fri, Mar 2, 2012 at 6:09 AM, Maxim Kuvyrkov <ma...@codesourcery.com> wrote: > On 1/03/2012, at 11:42 PM, Richard Guenther wrote: >> On Thu, Mar 1, 2012 at 6:28 AM, Maxim Kuvyrkov <ma...@codesourcery.com> >> wrote: >>> This patch disables graphite loop flattening optimization due to it being >>> effectively unmaintained. To avoid users trying to use unsupported >>> optimization and reporting bugs, Sebastian Pop suggested to disable the >>> optimization. >>> >>> Testing on x86_64 is underway. OK to apply provided no regressions? >> >> That cannot be enough, you need to adjust the testsuite as well. And >> if it is broken, >> why not remove it. Leaving unmaintained broken code in the repository is >> just >> a maintainance burden for no gain. >> >> So, please provide a complete removal patch (docs, making the option a >> dummy one, testcases, etc.) > > OK. The attached patch removes loop flattening optimization and updates > documentation and testsuite. > > Regtested on x86_64-linux-gnu with no regressions.
Ok for trunk with the invoke.texi change changed to simply remove all references to floop-fatten and common.opt to use floop-flatten Common Ignore Does nothing. Preserved for backward compatibility. Thanks, Richard. > -- > Maxim Kuvyrkov > CodeSourcery / Mentor Graphics >
