On Sun, 2021-11-21 at 00:47 -0300, Alexandre Oliva wrote:
> Hello, Giuliano, thanks for turning my suggestion into a patch!
>
> On Nov 19, 2021, Richard Biener <rguent...@suse.de> wrote:
>
> > > +/* { dg-options "-fdump-ipa-clones -o /dev/null" } */
>
> May I suggest actually checking that the ipa-clones dump file is
> created
> with the same name and the location it would without -o /dev/null? I
> think just using any of the normal dump file scanners would do.
>
> There's a larger set of tests in gcc.misc/outputs.exp, where this
> test
> would be a slightly better fit. Copying some of the tests under
> "Driver-chosen aux outputs", and some of the link tests that use
> '$oaout', changing them to use -o /dev/null without any changes to
> the
> expected output file names, would give us more coverage of expected
> behavior than just checking that we just don't get an error.
>
Hi, Oliva.
The patch was already applied in trunk and backported to gcc-11. The
rationale behind it was that exiting with an error because it couldn't
write dumps into /dev/* confused configure. Simply not erroring
(through not dumping in /dev/ on -o /dev/null) was enough to fix
configure, and the testcase reflects that.
As for moving that test to gcc.misc, I am not sure if that deserves
another patch just for that, and then applying it on gcc-11. I could do
that if it is really important, OTOH.
Thank you,
Giuliano.
> Thanks again,
>
