On Wed, Dec 1, 2021 at 10:54 AM Gerald Pfeifer <ger...@pfeifer.com> wrote: > > Hi Eric, > > On Wed, 24 Nov 2021, Eric Gallager wrote: > > This next patch does more than just removing old stuff: it adds an > > extra sentence to describe a shell command used to generate a list, so > > to verify that I've got the shell command right, I'm asking for a > > review. > > -<p>There are several other files in this size range, which I have left > +<p>There are several other files in this size range, which are left > out because touching them at all is unwise (reload, the Fortran front > end). You can try, but I am not responsible for any damage to your > sanity which may result.</p> > > while we are touching this, how about toning the second half of this > paragraph down and moving away from first person? > > How about something like "...breaking them up likely may prove rather > difficult" (or similar, happy to leave this to you as native spaker)? >
OK yeah I did remove the first instance of the first person in that paragraph, but couldn't think of a better wording for the second one, so that suggestion is helpful; thanks. > > +<p>Note that the list of large files in this section is generated with the > +following shell command, run from the gcc subdirectory:</p> > + > +<pre> > + du -sh *.{c,h,cc} */*.{c,h,cc} | sort -hr | grep -v fortran | head -n > 14 > +</pre> > > This looks like it does what you want it to do. > > (Pulling up the database courses I have given in a previous life, I'd pull > in the grep before the sort - O(n) filtering before O(n·log n) processing > - but even on my notebook both are instantenous. ;-) ) > > > Please consider the two suggestions above and commit the result; just > share the final patch here (no review required). > > Thanks, > Gerald OK thanks, I committed the attached patch as f4b4d0f: https://gcc.gnu.org/git/?p=gcc-wwwdocs.git;a=commitdiff;h=f4b4d0f783246dd6f58944cdb542446d5e7589d3
patch-beginner-projects-02.diff
Description: Binary data