Hi! On 12/1/21 5:00 PM, Segher Boessenkool wrote: > On Thu, Nov 18, 2021 at 10:36:52AM -0600, Bill Schmidt wrote: >> Hi! This is the last patch broken out of the previous test suite patch >> for the new builtins support. > Whew :-) > >> One advantage of the new builtins support is uniform error messages for >> arguments with restricted values. Previously this was done in many places >> in an ad hoc manner, with little uniformity. This patch adjusts the >> expected error messages accordingly. >> >> All such error messages are now one of the following: >> "argument %d must be a %d-bit unsigned literal" >> "argument %d must be a literal between %d and %d, inclusive" >> "argument %d must be a variable or a literal between %d and %d, inclusive" >> "argument %d must be either a literal %d or a literal %d" >> >> These messages were chosen to require the fewest changes from previous >> messages while still introducing uniformity. This patch adjusts error >> messages for some cases where this produces changed messages. In >> particular, some messages are improved because previously they did not >> admit the possibility that an argument could hold a variable. > Same comment as on the previous patch. But, okay for trunk. Thanks!
Thank you for all of the reviews! I combined recent patches that need to go upstream together to avoid bisect problems, and pushed them as r12-5752. The new built-in infrastructure is now enabled! I'll start working on a patch series to remove all the no longer needed code. Thanks again for all of your help in getting this work reviewed, and for all the improvements as a result! Bill > > > Segher
