On 28/10/2021 12:41, Tejas Belagod via Gcc-patches wrote:


-----Original Message-----
From: Richard Earnshaw <richard.earns...@arm.com>
Sent: Monday, October 11, 2021 1:29 PM
To: Tejas Belagod <tejas.bela...@arm.com>; gcc-patches@gcc.gnu.org
Subject: Re: [Patch 1/7, Arm, GCC] Add Armv8.1-M Mainline target feature
+pacbti.

On 08/10/2021 13:17, Tejas Belagod via Gcc-patches wrote:
Hi,

This patch adds the -march feature +pacbti to Armv8.1-M Mainline.
This feature enables pointer signing and authentication instructions
on M-class architectures.

Tested on arm-none-eabi. OK for trunk?

2021-10-04  Tejas Belagod  <tbela...@arm.com>

gcc/Changelog:

        * config/arm/arm-cpus.in: Define new feature pacbti.
        * config/arm/arm.h (TARGET_HAVE_PACBTI): New.


"+pacbti" needs to be documented in invoke.texi at the appropriate place.


Thanks for the reviews.

This patch adds the -march feature +pacbti to Armv8.1-M Mainline.
This feature enables pointer signing and authentication instructions
on M-class architectures.

2021-10-25  Tejas Belagod  <tbela...@arm.com>

gcc/Changelog:

        * config/arm/arm-cpus.in: Define new feature pacbti.
        * config/arm/arm.h (TARGET_HAVE_PACBTI): New.
        * doc/invoke.texi: Document new feature pacbti.

This isn't in the correct style:

gcc/Changelog:

        * config/arm/arm.h (TARGET_HAVE_PACBTI): New macro.
        * config/arm/arm-cpus.in (pacbti): New feature.
        * doc/invoke.texi (Arm Options): Document it.

would be better.



Tested the following configurations, OK for trunk?

-mthumb/-march=armv8.1-m.main+pacbti/-mfloat-abi=soft
-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp
mcmodel=small and tiny
aarch64-none-linux-gnu native test and bootstrap


R.

Otherwise OK.

R.

Reply via email to