On 12/6/2021 11:43 AM, Robin Dapp via Gcc-patches wrote:
If one of the to-be-converted SETs requires the original comparison
(i.e. in order to generate a min/max insn) but no other insn after it
does, we can omit creating temporaries, thus facilitating costing.
---
  gcc/ifcvt.c | 33 +++++++++++++++++++++++++++++++--
  1 file changed, 31 insertions(+), 2 deletions(-)
I'd generally prefer to refactor the bits between the restart label and the goto restart into a function and call it twice, passing in the additional bits to allow for better costing.  Can you look into that?  If it's going to be major surgery, then the goto approach will be OK.

Conceptually I don't have any concerns with the patch.  It'll obviously need a ChangeLog entry.

Jeff

Reply via email to