Re: [PATCH v3 2/2][GCC] arm: Declare MVE types internally via pragma

[Richard Earnshaw via Gcc-patches]

On 09/12/2021 15:24, Murray Steele via Gcc-patches wrote:
Changes from original patch:

1. Make mentioned changes to changelog.
2. Add namespace-end comments.
3. Add #error for when arm-mve-builtins.def is included without
    defining DEF_MVE_TYPE.
4. Make placement of '#undef DEF_MVE_TYPE' consistent.

---

This patch moves the implementation of MVE ACLE types from
arm_mve_types.h to inside GCC via a new pragma, which replaces the prior
type definitions. This allows for the types to be used internally for
intrinsic function definitions.

Bootstrapped and regression tested on arm-none-linux-gnuabihf, and
regression tested on arm-eabi -- no issues.

Thanks,
Murray

gcc/ChangeLog:

         * config.gcc: Add arm-mve-builtins.o to extra_objs.
         * config/arm/arm-c.c (arm_pragma_arm): Handle "#pragma GCC arm".
         (arm_register_target_pragmas): Register it.
         * config/arm/arm-protos.h: (arm_mve::arm_handle_mve_types_h): New
         prototype.
         * config/arm/arm_mve_types.h: Replace MVE type definitions with
         new pragma.
         * config/arm/t-arm: (arm-mve-builtins.o): New target rule.
         * config/arm/arm-mve-builtins.cc: New file.
         * config/arm/arm-mve-builtins.def: New file.
         * config/arm/arm-mve-builtins.h: New file.

gcc/testsuite/ChangeLog:

         * gcc.target/arm/mve/mve.exp: Add new subdirectories.
         * gcc.target/arm/mve/general-c/type_redef_1.c: New test.
         * gcc.target/arm/mve/general/double_pragmas_1.c: New test.
         * gcc.target/arm/mve/general/nomve_1.c: New test.


I fixed a minor issue in the changelog (config.gcc needs to mention 
arm*-*-* as the 'function') and pushed this.

Thanks,

R.