On Tue, 21 Dec 2021 at 17:56, François Dumont via Libstdc++ < libstd...@gcc.gnu.org> wrote:
> On 21/12/21 7:28 am, Daniel Krügler wrote: > > Am Di., 21. Dez. 2021 um 07:08 Uhr schrieb François Dumont via > > Libstdc++ <libstd...@gcc.gnu.org>: > >> Hi > >> > >> Is there a chance for this patch to be integrated for next gcc > >> release ? > >> > >> François > >> > > No counterargument for the acceptance, but: Shouldn't > > __small_size_threshold() be a noexcept function? > > > > - Daniel > > Could it enhance code generation ? I could make it depends on > _Hashtable_hash_traits<>::__small_size_threshold() noexcept > qualification if so. But I was hoping that the compiler to detect all > that itself. > > Otherwise no, it do not have to be noexcept as it is used to avoid > hasher invocation in some situations and hasher is not noexcept > constraint. At least I do not need to static_assert this. > > But why not make it noexcept? It just returns a constant integer. It can be noexcept.