Noted by Richard Sandiford in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103974#c7 (thanks!)

Mea culpa: I wrongly thought the default development-level value
("yes,extra") would include everything interesting to normal target
hacking (i.e. as opposed to hacking stuff like GC).  I see
rtl-checking is marked as "expensive" and presumably therefore left
out.  Maybe it could be split into rtl-static (cheap; catching type
errors including this kind of foulups) and rtl-dynamic (the expensive
parts).  I suppose that's for whomever feels a strong enough itch.

A quick (error-prone) grep-and-eyeball in config/ shows this was the
only file missing the parenthesis.  This lets cris-elf configured with
--enable-checking=yes,extra,rtl survive make all-gcc.

2022-01-11  Hans-Peter Nilsson  <h...@axis.com>

        * config/cris/cris.c (cris_postdbr_cmpelim): Parenthesize
        parameter to as_a.
---
 gcc/config/cris/cris.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/cris/cris.c b/gcc/config/cris/cris.c
index eff58435789e..ac1fc4909fc3 100644
--- a/gcc/config/cris/cris.c
+++ b/gcc/config/cris/cris.c
@@ -392,7 +392,7 @@ cris_postdbr_cmpelim ()
       /* Consider filled delay slots; there might be a comparison there.
         It's only the second insn in a sequence that is interesting.  */
       if (GET_CODE (pat) == SEQUENCE)
-       insn = as_a <rtx_insn *> XVECEXP (pat, 0, 1);
+       insn = as_a <rtx_insn *> (XVECEXP (pat, 0, 1));
       /* The "else" eliminates temptations to consider an insn in a
         delay slot for elimination; it can only be a prev_cc_setter.  */
       else if (prev_cc_setter != 0 && GET_CODE (pat) == SET)
-- 
2.30.2

brgds, H-P

Reply via email to