> > Ping - http://gcc.gnu.org/ml/gcc-patches/2012-03/msg00549.html > > And now really add Paolo and DJ.
+ [.type foo, '$target_type_format_char'gnu_unique_object],, This un-quoting looks incorrect if you don't know what's going on under the hood, but I don't see a clean way around it. A suitable comment would be appropriate. +target_type_format_char="@" + target_type_format_char="%" Since the string always has "special" characters, it's likely that single quotes are more appropriate here. The two characters in the patch don't care, but some future porter might naively do "$" and wonder why (or worse, not wonder why) it doesn't work right. Other than that it looks OK to me, assuming you tested it on all the relevent targets (i.e. arm and not-arm).
