Tobias, These patches are OK for trunk and fortran-dev.
Many thanks Paul On Sat, Mar 10, 2012 at 4:53 PM, Tobias Burnus <bur...@net-b.de> wrote: > The attached patch renames (in libgfortran/) the array descriptor's "data" > field to "base_addr" and "lbound" to "lower_bound". > > The reason is that Technical Specification (TS) 29113* uses those names in > their C bindings, defined in ISO_Fortran_binding.h. But I would like to > include that header file in libgfortran/libgfortran.h (cf. fortran-dev > branch). Hence, the renaming. > > In order to make later merging of the fortran-dev branch into the trunk > easier to review, I'd prefer to commit this patch already to the trunk, but > it can also be commit to the branch. > > The patch shouldn't have any effect in terms of the ABI, however, I am not > sure whether it formally fulfills the criteria in C99's 6.2.7p1** > (compatible type and composite type). On the other hand, the fields in the > dimension triplet are already differently named: "ubound" > (gcc/fortran/trans-types.c) vs. "_ubound" (libgfortran/libgfortran.h). > > Okay for the trunk? (Or for the fortran-dev branch?) Comments? > (Bootstrapped and regtested on x86-64-linux.) > > Tobias > > * Current TS 29113 draft: ftp://ftp.nag.co.uk/sc22wg5/N1901-N1950/N1904.pdf > ** C99 plus TC1 to TC3, > http://www.open-std.org/JTC1/SC22/WG14/www/docs/n1256.pdf -- The knack of flying is learning how to throw yourself at the ground and miss. --Hitchhikers Guide to the Galaxy
