On Thu, Jan 27, 2022 at 12:38:47PM +0100, Martin Liška wrote:
> Yep, we have many more examples where a leading capital letter is used:
>
> gcc/config/cris/cris.cc: internal_error ("MULT case in %<cris_op_str%>");
> gcc/config/cris/cris.h: do { if (!(x)) internal_error ("CRIS-port assertion
> failed: %s", #x); } while (0)
> gcc/config/mmix/mmix.cc: internal_error ("MMIX Internal: Last named vararg
> would not fit in a register");
> gcc/config/mmix/mmix.cc: internal_error ("MMIX Internal: Bad register:
> %d", regno);
> gcc/config/mmix/mmix.cc: internal_error ("MMIX Internal: Bad register:
> %d", regno);
> gcc/config/mmix/mmix.cc: internal_error ("MMIX Internal: Missing %qc
> case in %<mmix_print_operand%>", code);
> gcc/config/mmix/mmix.cc: internal_error ("MMIX Internal: Bad register:
> %d", regno);
> gcc/config/mmix/mmix.cc: internal_error ("MMIX Internal: %s is not a
> shiftable integer", s);
> gcc/config/mmix/mmix.cc: internal_error ("MMIX Internal: %s is not a
> shiftable integer", s);
> gcc/config/rs6000/host-darwin.cc: internal_error ("Segmentation Fault
> (code)");
> gcc/config/rs6000/host-darwin.cc: internal_error ("Segmentation Fault");
> gcc/d/decl.cc: internal_error ("Mismatch between declaration %qE size
> (%wd) and "
> gcc/fortran/arith.cc: gfc_internal_error ("Fix min_int calculation");
> gcc/fortran/data.cc: gfc_internal_error ("TODO: Vector sections in data
> statements");
> gcc/fortran/decl.cc: gfc_internal_error ("Cannot set pointee
> array spec.");
> gcc/fortran/decl.cc: gfc_internal_error ("Missing symbol");
> gcc/fortran/decl.cc: gfc_internal_error ("Cannot set Cray pointee
> array spec.");
> gcc/fortran/decl.cc: gfc_internal_error ("Failed to create structure
> type '%s' at %C", name);
> gcc/fortran/frontend-passes.cc: gfc_internal_error ("Illegal id in
> copy_walk_reduction_arg");
> gcc/fortran/frontend-passes.cc: gfc_internal_error ("Scalarization
> using DIMEN_RANGE unimplemented");
> gcc/fortran/interface.cc: gfc_internal_error ("Unable to find symbol %qs",
> sym->name);
> gcc/fortran/intrinsic.cc: gfc_internal_error ("Invalid standard code on
> intrinsic %qs (%d)",
> gcc/fortran/intrinsic.cc: gfc_internal_error ("Cannot convert %qs to %qs at
> %L", type_name,
> gcc/fortran/simplify.cc: gfc_internal_error ("IBITS: Bad bit");
> gcc/fortran/simplify.cc: gfc_internal_error ("Reshaped array too large
> at %C");
> gcc/fortran/simplify.cc: gfc_internal_error ("Bad type in
> gfc_simplify_sign");
> gcc/fortran/simplify.cc: gfc_internal_error ("Failure getting length
> of a constant array.");
> gcc/fortran/simplify.cc: gfc_internal_error ("Failure getting length of a
> constant array.");
> gcc/fortran/target-memory.cc: gfc_internal_error ("Invalid expression in
> gfc_element_size.");
> gcc/fortran/target-memory.cc: gfc_internal_error ("Invalid expression in
> gfc_target_encode_expr.");
> gcc/fortran/target-memory.cc: gfc_internal_error ("Invalid expression in
> gfc_target_interpret_expr.");
> gcc/fortran/trans-intrinsic.cc: gfc_internal_error ("Intrinsic function
> %qs (%d) not recognized",
> gcc/fortran/trans-io.cc: gfc_internal_error ("Bad IO basetype (%d)",
> ts->type);
> gcc/ipa-sra.cc: internal_error ("IPA-SRA access verification failed");
> gcc/ipa-sra.cc: internal_error ("Function %qs, parameter %u, has IPA-SRA
> accesses "
> gcc/ipa-sra.cc: internal_error ("Function %s, parameter %u, is used but does
> not "
> gcc/rtl.cc: internal_error ("RTL check: expected code '%s', have '%s' in %s,
> at %s:%d",
> gcc/tree-into-ssa.cc: internal_error ("SSA corruption");
> gcc/tree-outof-ssa.cc: internal_error ("SSA corruption");
> gcc/tree-ssa-coalesce.cc: internal_error ("SSA corruption");
> gcc/varasm.cc: internal_error ("Section already exists: %qs", name);
>
> I can prepare a separate patch for next stage1 if you want?
Ok. MMIX, MULT, CRIS, IPA-SRA, SSA all look desirable to be
capitalized. And I'd leave out gcc/fortran/, it has very different rules
and I think generally capitalizes diagnostics.
> PR web/104254
>
> gcc/ChangeLog:
>
> * diagnostic.cc (diagnostic_initialize):
> Initialize report_bug flag.
> (diagnostic_action_after_output):
> Explain that -freport-bug option can be used for pre-processed
> file creation. Make the message shorter.
> (error_recursion): Rename Internal to internal.
> * diagnostic.h (struct diagnostic_context): New field.
> * opts.cc (common_handle_option): Init the field here.
Ok, thanks.
Jakub
