On Wed, Jan 26, 2022 at 03:50:35PM -0500, David Edelsohn via Gcc-patches wrote: > On Wed, Jan 26, 2022 at 3:45 PM Jakub Jelinek <ja...@redhat.com> wrote: > > r12-4717-g7d37abedf58d66 added immintrin.h and x86gprintrin.h headers > > to rs6000, these headers are on x86 standalone headers that various > > programs include directly rather than including them through > > <x86intrin.h>. > > Unfortunately, for that change the bmiintrin.h and bmi2intrin.h > > headers haven't been adjusted, so the effect is that if one includes them > > (without including also x86intrin.h first) #error will trigger. > > Furthermore, when including such headers conditionally as some real-world > > packages do, this means a regression. > > > > The following patch fixes it and matches what the x86 bmi{,2}intrin.h > > headers do. > > Okay. > > Thanks for catching this.
Indeed, thanks. And thanks for reviewing, David. Should we add similar compile-only tests for all of the standalone include files? PC