Hi Martin,
> Either this:
>
> error ("%<attribute(target(\"%s\"))%> is unknown", orig_p);
>
> or this would be better:
>
> error ("attribute %<target(\"%s\")%> is unknown", orig_p);
>
> The %< %> directives will render it in single quotes like keywords and
> identifiers. Using %qs would render it in double quotes like a string,
> which wouldn't be quite right.
the x86 backend will print the error message in a different format using
single quotes e.g.
bla.cc:2:5: error: attribute ‘bleh’ argument ‘target’ is unknown
I don't find that better to be frank but maybe it would make sense for
us to also adopt this error message style and not use a different one?
They use %qs, though - or is there an intention to also change x86's
error messages? I guess in general it's better to have similar error
messages across targets for the same problem.
Regards
Robin
