Hi!
I'd like to ping the following patch.
Thanks.
On Thu, Jan 27, 2022 at 11:07:26AM +0100, Jakub Jelinek via Gcc-patches wrote:
> On Thu, Jan 20, 2022 at 11:27:20AM +0000, Richard Earnshaw via Gcc-patches
> wrote:
> > gcc/ChangeLog:
> >
> > * config/arm/arm.opt (mfix-cortex-a57-aes-1742098): New command-line
> > option.
> > (mfix-cortex-a72-aes-1655431): New option alias.
>
> > --- a/gcc/config/arm/arm.opt
> > +++ b/gcc/config/arm/arm.opt
> > @@ -272,6 +272,16 @@ mfix-cmse-cve-2021-35465
> > Target Var(fix_vlldm) Init(2)
> > Mitigate issues with VLLDM on some M-profile devices (CVE-2021-35465).
> >
> > +mfix-cortex-a57-aes-1742098
> > +Target Var(fix_aes_erratum_1742098) Init(2) Save
> > +Mitigate issues with AES instructions on Cortex-A57 and Cortex-A72.
> > +Arm erratum #1742098
> > +
> > +mfix-cortex-a72-aes-1655431
> > +Target Alias(mfix-cortex-a57-aes-1742098)
> > +Mitigate issues with AES instructions on Cortex-A57 and Cortex-A72.
> > +Arm erratum #1655431
> > +
> > munaligned-access
> > Target Var(unaligned_access) Init(2) Save
> > Enable unaligned word and halfword accesses to packed data.
>
> This breaks:
> Running /usr/src/gcc/gcc/testsuite/gcc.misc-tests/help.exp ...
> FAIL: compiler driver --help=target option(s): "^ +-.*[^:.]$" absent from
> output: " -mfix-cortex-a57-aes-1742098 Mitigate issues with AES instructions
> on Cortex-A57 and Cortex-A72. Arm erratum #1742098"
>
> help.exp with help of lib/options.exp tests whether all non-empty
> descriptions of
> options are terminated with . or :.
>
> The following patch fixes that, ok for trunk?
>
> 2022-01-27 Jakub Jelinek <ja...@redhat.com>
>
> * config/arm/arm.opt (mfix-cortex-a57-aes-1742098,
> mfix-cortex-a72-aes-1655431): Ensure description ends with full stop.
>
> --- gcc/config/arm/arm.opt.jj 2022-01-21 22:43:22.879719389 +0100
> +++ gcc/config/arm/arm.opt 2022-01-27 11:02:29.457553296 +0100
> @@ -274,13 +274,13 @@ Mitigate issues with VLLDM on some M-pro
>
> mfix-cortex-a57-aes-1742098
> Target Var(fix_aes_erratum_1742098) Init(2) Save
> -Mitigate issues with AES instructions on Cortex-A57 and Cortex-A72.
> -Arm erratum #1742098
> +Mitigate issues with AES instructions on Cortex-A57 and Cortex-A72
> +(Arm erratum #1742098).
>
> mfix-cortex-a72-aes-1655431
> Target Alias(mfix-cortex-a57-aes-1742098)
> -Mitigate issues with AES instructions on Cortex-A57 and Cortex-A72.
> -Arm erratum #1655431
> +Mitigate issues with AES instructions on Cortex-A57 and Cortex-A72
> +(Arm erratum #1655431).
>
> munaligned-access
> Target Var(unaligned_access) Init(2) Save
Jakub
