> In the past stack sharing has been quite important for the linux > kernel. So perhaps one of the tests we should do if we wanted to go > forward in this cycle would be to test kernel builds to see if any start > tripping over the stack space diagnostics they've put in place over the > years.
Stack slot sharing is important generally speaking, not just for the kernel. As demonstrated by the recent controversy about the 1/X optimization, last- minute broad changes made during stage #4 are generally not a good idea, and I'm not sure what the incentive for fixing PR middle-end/90348 now is (it's labeled a 9/10/11/12 regression). At a minimum, I think that a switch to revert to the pre-12 behavior would be in order if the patch goes in now. -- Eric Botcazou