On Mon, 12 Mar 2012, Rainer Orth wrote:

> With the IRIX port gone (shortly), there are no targets that define a
> non-default DWARF_OFFSET_SIZE or DWARF_INITIAL_LENGTH_SIZE any longer.
> I therefore propose to remove the code handling this.

As a *target macro* it makes sense to remove it - reomve it from 
defaults.h, make it purely internal to dwarf2out.c.  But I think it makes 
sense to have it inside dwarf2out.c - to indicate that a particular "4" is 
actually the size of an offset (which could be 8 if 64-bit DWARF were 
generated) rather than some other source of the magic number "4" (in 
general I think using meaningful names is better than such magic numbers, 
especially given that in the DWARF specification this is not a constant 
4).

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to