On Mon, Feb 21, 2022 at 03:17:46PM -0600, Paul A. Clarke wrote:
> Also adjust DejaGnu directives, as specifically requiring "powerpc*-*-*" is no
> longer required.
> 
> 2021-02-21  Paul A. Clarke  <p...@us.ibm.com>
> 
> gcc/testsuite
>       * g++.dg/pr65240.h: Move to g++.target/powerpc.
>       * g++.dg/pr93974.C: Likewise.
>       * g++.dg/pr65240-1.C: Move to g++.target/powerpc, adjust dg directives.
>       * g++.dg/pr65240-2.C: Likewise.
>       * g++.dg/pr65240-3.C: Likewise.
>       * g++.dg/pr65240-4.C: Likewise.
>       * g++.dg/pr65242.C: Likewise.
>       * g++.dg/pr67211.C: Likewise.
>       * g++.dg/pr69667.C: Likewise.
>       * g++.dg/pr71294.C: Likewise.
>       * g++.dg/pr84264.C: Likewise.
>       * g++.dg/pr84279.C: Likewise.
>       * g++.dg/pr85657.C: Likewise.

Okay for trunk.  Thanks!

That said...

> -/* { dg-do compile { target { powerpc*-*-* && lp64 } } } */
> -/* { dg-skip-if "" { powerpc*-*-darwin* } } */
> +/* { dg-do compile { target lp64 } } */
> +/* { dg-skip-if "" { *-*-darwin* } } */

That skip-if is most likely cargo cult, and it's not clear why lp64
would be needed either (there is no comment what it is needed for, for
example).

> --- a/gcc/testsuite/g++.dg/pr85657.C
> +++ b/gcc/testsuite/g++.target/powerpc/pr85657.C
> @@ -1,4 +1,4 @@
> -// { dg-do compile { target { powerpc*-*-linux* } } }
> +// { dg-do compile { target { *-*-linux* } } }

A comment here would help as well.  All of that is pre-existing of
course.


Segher

Reply via email to