On Thu, Mar 10, 2022 at 01:49:36PM -0600, Segher Boessenkool wrote: > On Thu, Mar 10, 2022 at 10:44:52AM -0600, will schmidt wrote: > > On Wed, 2022-03-09 at 22:49 -0500, Michael Meissner wrote: > > > --- a/gcc/config/rs6000/rs6000-cpus.def > > > +++ b/gcc/config/rs6000/rs6000-cpus.def > > > @@ -43,9 +43,7 @@ > > > | OPTION_MASK_ALTIVEC \ > > > | OPTION_MASK_VSX) > > > > > > -/* For now, don't provide an embedded version of ISA 2.07. Do not set > > > power8 > > > - fusion here, instead set it in rs6000.cc if we are tuning for a power8 > > > - system. */ > > > +/* For now, don't provide an embedded version of ISA 2.07. */ > > > > ok. (as far as removing the comment, I'm not clear what the remaining > > comment is telling me, but thats outside of the scope of this patch). > > It is saying there is nothing that implements Book III-E of ISA 2.07 > (nothing in GCC, but no actual CPU either). Or Category: Embedded even > maybe :-) > > It could be clearer perhaps, or just be removed completely; it might > have been useful historically, but it isn't anymore really.
Other than possibly removing the comment, are there other things about the patch that need to be done? -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meiss...@linux.ibm.com
