Make vsx_extract_<mode> use correct insn attributes, PR target 99293.
In looking at PR target/99293, I noticed that the insn "type" attribute is
incorrect for the vsx_extract_<mode> insns. In particular:
1) Simple vector register move should be vecmove (alternative 1);
2) Xxpermdi should be vecperm (alternative 2); (and)
3) Mfvsrld should be mfvsr (alternative 4).
This patch fixes those attributes.
I have built the spec 2017 benchmark with this patch (#3) and the previous
patch (#2), along with the first patch in the series for power9 and
power10 targets. Most of the floating point benchmarks changed code
slightly, due to the scheduling changes that came from changing the insn
type attribute. I ran the spec 2017 suite on power9, and I did not not
notice any significant changes from these changes.
The power9 benchmarks that had code differences with these 2 patches
applied in addition to the build with just the first patch applied were:
namd_r, pareset_r, povray_r, wrf_r, blender_r, cam4_r,
deepsjeng_r, imagick_r, roms_r
The power9 benchmarks that had code differences with these 2 patches
applied in addition to the build with just the first patch applied were
(cactuBSSN_r had changes for power10 but not power9):
cactuBSSN_r, namd_r, pareset_r, povray_r, wrf_r, blender_r,
cam4_r, deepsjeng_r, imagick_r, nab_r, roms_r
I have built bootstrap versions on the following systems. There were no
regressions in the runs:
Power9 little endian, --with-cpu=power9
Power10 little endian, --with-cpu=power10
Power8 big endian, --with-cpu=power8 (both 32-bit & 64-bit tests)
Can I install this into the trunk? After a burn-in period, can I backport
and install this into GCC 11 and GCC 10 branches?
2022-03-28 Michael Meissner <meiss...@linux.ibm.com>
gcc/
PR target/99293
* config/rs6000/rs6000.md (vsx_extract_<mode>): Use the correct
insn type for the alternatives.
---
gcc/config/rs6000/vsx.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md
index ad722cff70f..2a23807c2dc 100644
--- a/gcc/config/rs6000/vsx.md
+++ b/gcc/config/rs6000/vsx.md
@@ -3451,7 +3451,7 @@ (define_insn "vsx_extract_<mode>"
else
gcc_unreachable ();
}
- [(set_attr "type" "veclogical,mfvsr,mfvsr,vecperm")
+ [(set_attr "type" "vecmove,vecperm,mfvsr,mfvsr")
(set_attr "isa" "*,*,p8v,p9v")])
;; Optimize extracting a single scalar element from memory.
--
2.35.1
--
Michael Meissner, IBM
PO Box 98, Ayer, Massachusetts, USA, 01432
email: meiss...@linux.ibm.com
