On Tue, 29 Mar 2022, Thomas Schwinge wrote: > I'm generally very much in favor of abstracting functionality into > separate functions. Here, however, there ever existed only one user of > 'gcc/opt-functions.awk:lang_enabled_by', its interface is a bit clumsy, > leading to (slightly) confusing diagnostics, and all handling for other > related option properties remains in the original place, so I find that > in fact confusing to be split out, and scattered over two files. I thus > propose to merge 'gcc/opt-functions.awk:lang_enabled_by' back into its > original place, and then improve diagnostics. OK to push the attached > "options: Improve 'LangEnabledBy' option property diagnostics"? In > addition to standard testing, I've manually verified the error cases.
OK. -- Joseph S. Myers jos...@codesourcery.com
