On Thu, 28 Apr 2022 15:22:37 PDT (-0700), jos...@codesourcery.com wrote:
On Thu, 28 Apr 2022, Palmer Dabbelt wrote:On Thu, 28 Apr 2022 15:12:39 PDT (-0700), jos...@codesourcery.com wrote: > On Thu, 28 Apr 2022, Palmer Dabbelt wrote: > > > +proc check_effective_target_fenv_setround {} { > > + return [check_runtime fenv_setround { > > + #include <fenv.h> > > + #include <stdlib.h> > > + int > > + main (void) > > + { > > + if (fesetround (1) == 0) > > There is no reason to expect that 1 is a valid argument to fesetround. > (It isn't with x86 glibc, for example.) You need to use whatever FE_* > rounding mode macro the test in question cares about. Sorry, I mis-read the man page and thought that list of numbers was ABI. At least some of the tests are using all the rounding modes, so unless you think it's worth splitting up both the tests and the DG check I'll just check for all of them?I think checking for all four of the IEEE binary rounding modes is reasonable. (If we add support for FE_TONEARESTFROMZERO in RISC-V glibc, that ought to be handled separately for any GCC tests involving that rounding mode, given that most architectures don't support it.)
Yep, I was just talking about the IEEE modes. I'll send a v2.
