Hi, Uros Bizjak <ubiz...@gmail.com> wrote: > > > > gcc/ChangeLog: > > > > > > > > * config/i386/gnu-user-common.h (defined): Only define > > > > TARGET_CAN_SPLIT_STACK for glibc targets. > > > > * config/i386/gnu.h (defined): Ditto. > > This looks good to me, so OK. > > Thanks, > Uros.
I am not deeply familiar with the GCC development process but since it seems that this hasn't been merged yet: Is there anything else that I need to do or what is the process for getting this patch upstreamed? (: Thank you, Sören > > > > --- > > > > Changes since v1: Use (DEFAULT_LIBC == LIBC_GLIBC) instead of > > > > OPTION_GLIBC_P to detect use of glibc in a pre-processor context. > > > > > > > > Is there a better way to detect use of glibc in the config header? > > > > > > > > gcc/config/i386/gnu-user-common.h | 5 +++-- > > > > gcc/config/i386/gnu.h | 5 +++-- > > > > 2 files changed, 6 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/gcc/config/i386/gnu-user-common.h > > > > b/gcc/config/i386/gnu-user-common.h > > > > index 00226f5a455..e126c3fa9fa 100644 > > > > --- a/gcc/config/i386/gnu-user-common.h > > > > +++ b/gcc/config/i386/gnu-user-common.h > > > > @@ -66,7 +66,8 @@ along with GCC; see the file COPYING3. If not see > > > > #define STACK_CHECK_STATIC_BUILTIN 1 > > > > > > > > /* We only build the -fsplit-stack support in libgcc if the > > > > - assembler has full support for the CFI directives. */ > > > > -#if HAVE_GAS_CFI_PERSONALITY_DIRECTIVE > > > > + assembler has full support for the CFI directives. Also > > > > + we only support -fsplit-stack on glibc targets. */ > > > > +#if HAVE_GAS_CFI_PERSONALITY_DIRECTIVE && (DEFAULT_LIBC == LIBC_GLIBC) > > > > #define TARGET_CAN_SPLIT_STACK > > > > #endif > > > > diff --git a/gcc/config/i386/gnu.h b/gcc/config/i386/gnu.h > > > > index 25fbc07f58c..17494333bb9 100644 > > > > --- a/gcc/config/i386/gnu.h > > > > +++ b/gcc/config/i386/gnu.h > > > > @@ -41,8 +41,9 @@ along with GCC. If not, see > > > > <http://www.gnu.org/licenses/>. > > > > #define TARGET_THREAD_SSP_OFFSET 0x14 > > > > > > > > /* We only build the -fsplit-stack support in libgcc if the > > > > - assembler has full support for the CFI directives. */ > > > > -#if HAVE_GAS_CFI_PERSONALITY_DIRECTIVE > > > > + assembler has full support for the CFI directives. Also > > > > + we only support -fsplit-stack on glibc targets. */ > > > > +#if HAVE_GAS_CFI_PERSONALITY_DIRECTIVE && (DEFAULT_LIBC == LIBC_GLIBC) > > > > #define TARGET_CAN_SPLIT_STACK > > > > #endif > > > > /* We steal the last transactional memory word. */
