On Tue, Jun 07, 2022 at 11:45:13AM -0500, will schmidt wrote: > Additional comments below. > I've made note of the comments, and request (ask) that this be > approved, with a pinky promise that I intend to follow up on the > suggestions in my next patch series.
Suggestions aren't requirements :-) > > If we drop bu_mask in function rs6000_target_modify_macros, function > > rs6000_builtin_mask_calculate will have only one use place in > > function > > rs6000_option_override_internal. IMHO this function > > rs6000_builtin_mask_calculate also becomes stale after built-in > > function > > rewriting and needs some updates with new bif framework later. > > The DEBUG output using the builtin_mask still appeared to have some > potential value, but I can make a point to investigate that further. "Potential value" is a value of zero, if not a negative value. If some debug output has real and current value (which are two sides of the same coin), it will be apparent to every reader. Debug output that isn't useful currently is throw-away, and should be thrown away. It is easy to recreate (it is a totally boring number of print statements after all), and you can pull it from git history anyway. Segher
