On 6/7/22 4:24 PM, Segher Boessenkool wrote: > On Tue, Jun 07, 2022 at 04:17:04PM -0500, Peter Bergner wrote: >> I think I mentioned this offline, but I'd prefer a negative target flag, >> something like TARGET_NO_STORE_VECTOR_PAIR that defaults to off, meaning we'd >> generate stxvp by default. > > NAK. All negatives should be -mno-xxx with -mxxx the corresponding > positive. All of them.
That's not what I was asking for. I totally agree that -mno-store-vector-pair should disable generating stxvp and that -mstore-vector-pair should enable generating it. What I asked for was that the internal flag we use to enable and disable it should be a negative flag, where TARGET_NO_STORE_VECTOR_PAIR is true when we use -mno-store-vector-pair and false when using -mstore-vector-pair. That way we can add that flag to power10's rs6000-cpu.def entry and then we're done. What I don't want to have to do is that if/when power87 is released, we still have to add TARGET_STORE_VECTOR_PAIR its rs6000-cpu.def entry just to get stxvp insns generated. That adds a cost to every cpu after power10 since we'd have to remember to add that flag to every follow-on cpu. Peter
