> On Jun 28, 2022, at 11:08 AM, Jakub Jelinek <ja...@redhat.com> wrote: > > On Tue, Jun 28, 2022 at 03:03:12PM +0000, Qing Zhao wrote: >> 2. Then replace all “array_at_struct_end_p” with using DECL_NOT_FLEXARRAY in >> GCC, adding new testing cases > > No, IMHO array_at_struct_end_p should stay as is, just test this extra flag > too.
Could you please explain why we still need “array_at_struct_end_p” after we have the DECL_NOT_FLEXARRAY flag in FIELD_DECL? In addition to serve the purpose to check whether an array might be a flexible array, what else this function “array_at_struct_end_p” will do? Thanks. Qing > > Jakub >