On Tue, Jun 28, 2022 at 11:11:55AM +0000, Richard Biener wrote:
> The following makes sure we preserve EH notes on call insns that
> indicate the call doesn't perform a non-local goto when distributing
> notes after combining insns.

> -         if (!insn_could_throw_p (from_insn))
> -           /* Throw away stra notes on insns that can never throw.  */
> +         if (!insn_could_throw_p (from_insn)
> +             && (lp_nr != INT_MIN || !can_nonlocal_goto (from_insn)))
> +           /* Throw away stray notes on insns that can never throw or
> +              make a nonlocal goto.  */
>             ;

Where is the meaning of INT_MIN here documented?

... Ah, in except.cc .

Can you write this as

            if (!insn_could_throw_p (from_insn)
                && !(lp_nr == INT_MIN && can_nonlocal_goto (from_insn)))

please?  It is easier to understand that way.

With or without that, okay for trunk.  Thanks!


Segher

Reply via email to