On 6/23/22 13:03, Lewis Hyatt via Gcc-patches wrote:
Hello-
https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595556.html
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53431#c49
Would a C++ maintainer have some time to take a look at this patch
please? I feel like the PR is still worth resolving. If this doesn't
seem like a good way, I am happy to try another -- would really
appreciate any feedback. Thanks!
Thanks for your persistence, I'll take a look now.
Incidentally, when pinging it's often useful to ping someone from
MAINTAINERS directly, as well as the list. I think your last ping got
eaten by some trouble Red Hat email was having at the time.
The cp_token_is_module_directive cleanup is OK.
+ bool skip_this_pragma;
This member seems to be equivalent to
in_pragma && !should_output_pragmas ()
Maybe it could be a member function instead of a data member?
More soon.
Jason
