Hi!
On Wed, Jul 13, 2022 at 01:18:29PM -0500, will schmidt wrote:
> This cleans up some of the naming around the vstrir and vstril
> instruction definitions, with some cosmetic changes for consistency.
> gcc/
> * config/rs6000/altivec.md (vstrir_code_<mode>): Rename
> to vstrir_internal_<mode>.
> (vstrir_p_code_<mode>): Rename to vstrir_p_internal_<mode>.
> (vstril_code_<mode>): Rename to vstril_internal_<mode>.
> (vstril_p_code_<mode>): Rename to vstril_p_internal_<mode>.
It doesn't show the new names on the lhs this way. One way to do
better
is to write e.g.
(vstril_code_<mode>): Rename to...
(vstril_internal_<mode>): ... this.
It often is a good idea to say "...<mode> for VIshort" and similar btw.
I'm not a fan of "internal" either, it doesn't say anything. At least
put it at the very end of the names please?
Okay for trunk with that changed. Thanks!
Segher
