Could you also clean up all __riscv_cmodel_pic checking in gcc/testsuite/gcc.target/riscv/predef-*.c?
On Wed, Aug 31, 2022 at 10:58 PM Palmer Dabbelt <pal...@rivosinc.com> wrote: > > On Tue, 30 Aug 2022 10:48:29 PDT (-0700), Vineet Gupta wrote: > > Came across this deprecated symbol when looking around for > > -mexplicit-relocs handling in code > > > > Signed-off-by: Vineet Gupta <vine...@rivosinc.com> > > --- > > gcc/config/riscv/riscv-c.cc | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/gcc/config/riscv/riscv-c.cc b/gcc/config/riscv/riscv-c.cc > > index eb7ef09297e9..bba72cf77a82 100644 > > --- a/gcc/config/riscv/riscv-c.cc > > +++ b/gcc/config/riscv/riscv-c.cc > > @@ -93,9 +93,6 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile) > > break; > > > > case CM_PIC: > > - /* __riscv_cmodel_pic is deprecated, and will removed in next GCC > > release. > > - see https://github.com/riscv/riscv-c-api-doc/pull/11 */ > > - builtin_define ("__riscv_cmodel_pic"); > > /* FALLTHROUGH. */ > > > > case CM_MEDANY: > > It looks like some of the tests > (gcc/testsuite/gcc.target/riscv/predef-3.c, for example) are checking > for __riscv_cmodel_pic. From looking at them I'd expect them to fail, > but even if they're not we should clean them up.
