Hi Segher,
on 2022/9/1 22:57, Segher Boessenkool wrote:
> On Thu, Sep 01, 2022 at 04:57:59PM +0800, Kewen.Lin wrote:
>> on 2022/8/31 22:13, Peter Bergner wrote:
>>> On 8/31/22 4:33 AM, Kewen.Lin wrote:
>>>> @@ -1,7 +1,8 @@
>>>> /* { dg-do compile { target { powerpc*-*-* } } } */
>>>> /* { dg-skip-if "" { powerpc*-*-aix* } } */
>>>> -/* { dg-options "-O2 -mpowerpc64" } */
>>>> /* { dg-require-effective-target ilp32 } */
>>>> +/* { dg-options "-O2 -mpowerpc64" } */
>>>> +/* { dg-require-effective-target has_arch_ppc64 } */
>>>
>>> With many of our recent patches moving the dg-options before any
>>> dg-requires-effectice-target so it affects the results of the
>>> dg-requires-effectice-target test, this looks like it's backwards
>>> from that process. I understand why, so I think an explicit comment
>>> here in the test case explaining why it's after in this case.
>>> Just so in a few years when we come back to this test case, we
>>> won't accidentally undo this change.
>>
>> Oops, the diff shows it's like "after", but it's actually still "before". :)
>> The dg-options is meant to be placed before the succeeding has_arch_ppc64
>> effective target which is supposed to use dg-options to compile. I felt
>> good to let ilp32 checking go first then has_arch_ppc64, so moved dg-option
>> downward.
>
> These two are independent, but apparently we have a bug here, which will
> make what you did malfunction in some cases -- the test will not run for
> ilp32 if you have RUNTESTFLAGS {-m32,-m64}.
Yeah, because of the bug (or call it surprised behavior), the test case can
fail for some dejaGnu version like 1.5.1 (how it places the dg-options matters).
What I proposed is to detect this kind of test environment by has_arch_ppc64,
then turn the failure into unsupported. Then the test case can survive for
any dejaGnu versions. But based on the discussions, I'd like to try to fix
the bug and abandon this testing fix first.
>
> It should not make a difference, -mpowerpc64 and -m32 should be wholly
> independent, and their order should not matter. So the order of the
> /* { dg-require-effective-target ilp32 } */
> /* { dg-options "-O2 -mpowerpc64" } */
> lines should not make a difference either. But it does :-(
>
I agree the point that the order of lines should not make a difference. :)
But to be clarified, the order of
/* { dg-options "-O2 -mpowerpc64" } */
and
/* { dg-require-effective-target has_arch_ppc64 } */
matters in this proposed fix, not for the line with ilp32.
has_arch_ppc64 uses current_compiler_flags which only incorporates dg-options
which is placed before the dg-require-effective-target. I guess it's related
to how dejaGnu parses lines and sets global variables, for this kind of case,
we have to put the expected order for now.
BR,
Kewen
