on 2022/9/2 11:23, HAO CHEN GUI wrote: > Hi Kewen, > > On 1/9/2022 下午 5:34, Kewen.Lin wrote: >> Thanks for the updated patch! >> >> I just found that it seems all the three test cases suffer the empty >> TU error issue from those has_arch* effective target checks? >> >> If yes, it looks we don't need to bother this once patch [1] gets >> landed? >> >> Sorry, I didn't notice and ask when reviewing the previous version. >> >> [1] https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598748.html > > Yes, those 3 test cases all suffer from "empty translation unit" problem. > My patch just has an side effect which avoid "empty translation unit" > problem. But the real problem is still there.
OK, thanks for the information! If so, I would prefer to leave them alone for now, the issues should be fixed once [1] gets landed. > > pr92398.p9+.c has another problem. It's a compiling case and it should be > compiled on any platform when "-mdejagnu-cpu=power9" is set in dg-options > or RUNTESTFLAGS. Putting dg-options before "has_arch_pwr9" check achieves > this target. OK, then go ahead to enhance it separately. :) BR, Kewen