On 9/6/22 19:00, David Edelsohn wrote: > * dwarf2out.cc (XCOFF_DEBUGGING_INFO): Likewise. > (HAVE_XCOFF_DWARF_EXTRAS): Likewise. > (output_fde): Likewise. > (output_call_frame_info): Likewise. > (have_macinfo): Likewise. > (add_AT_loc_list): Likewise. > (add_AT_view_list): Likewise. > (output_compilation_unit_header): Likewise. > (output_pubnames): Likewise. > (output_aranges): Likewise. > (output_line_info): Likewise. > (output_macinfo): Likewise. > (dwarf2out_finish): Likewise. > (dwarf2out_early_finish): Likewise. > > These changes are not correct and break AIX bootstrap. > > Those changes are not related to stabs support. We agreed to remove stabs and > > XCOFF stabs support, not GCC DWARF debugging support for AIX.
Sorry for the breakage, I've just sent a patch that restores that. Cheers, Martin > > Also > > * configure: Regenerate. Likewise. > * configure.ac <http://configure.ac>: Likewise. > > does not list that tests for HAVE_XCOFF_DWARF_EXTRAS was removed, so the > ChangeLog was not accurate. > > Again, that test is required for AIX is not part of stabs support. > > > Please revert this change so that AIX can continue to be bootstrapped and > tested, and we can work together to test a corrected patch. > > Thanks, David > > > On Tue, Sep 6, 2022 at 12:31 PM David Edelsohn <dje....@gmail.com > <mailto:dje....@gmail.com>> wrote: > > I fully support the plan to remove stabs support, but this patch broke > bootstrap on AIX. It seems rather bad policy to remove support for a feature > without ensuring that the removal does not negatively impact the targets > touched by the patch. I should have been explicitly copied on these patches > and I should have been asked to test the patches before they were installed, > if for no other reason than politeness and consideration. > > Thanks, David > >
