On Fri, Mar 30, 2012 at 1:23 PM, Jack Howarth <howa...@bromo.med.uc.edu> wrote: > On Fri, Mar 30, 2012 at 11:32:37AM -0700, H.J. Lu wrote: >> On Fri, Mar 30, 2012 at 11:05 AM, Jack Howarth <howa...@bromo.med.uc.edu> >> wrote: >> > On Fri, Mar 30, 2012 at 09:18:13AM -0700, H.J. Lu wrote: >> >> On Fri, Mar 30, 2012 at 8:11 AM, Rainer Orth >> >> <r...@cebitec.uni-bielefeld.de> wrote: >> >> > Mike Stump <mikest...@comcast.net> writes: >> >> > >> >> >>> Here is the new patch. OK for trunk if there are no regressions on >> >> >>> Linux/ia32 and Linux/x86-64? >> >> >> >> >> >> Too bad you didn't test 32-bit darwin, causes: >> >> >> >> >> >> http://gcc.gnu.org/PR52784 >> >> >> >> >> >> Could you please revert or fix, thanks. >> >> > >> >> > Same problem on Solaris 10 and 11/x86. >> >> > >> >> > Rainer >> >> > >> >> >> >> When i[34567]86-*-* targets are configured with --enable-targets=all, >> >> TARGET_BI_ARCH is defined as 1, but TARGET_64BIT_DEFAULT >> >> isn't defined. It leads to >> >> >> >> if (!TARGET_64BIT) >> >> ix86_isa_flags &= ~(OPTION_MASK_ABI_64 | OPTION_MASK_ABI_X32); >> >> >> >> Since TARGET_64BIT is false by default, -m64 and -mx32 don't work >> >> correctly. This patch changes TARGET_BI_ARCH to 3 for >> >> i[34567]86-*-* targets configured with --enable-targets=all. Tested on >> >> Linux/ia32 with bootstrap and Linux/ia32 with --enable-targets=all >> >> --disable-bootstrap. Please try on other OSes. >> > >> > H.J., >> > This patch solves the bootstrap of current gcc trunk on >> > i386-apple-darwin10. Thanks. >> > Jack >> > >> >> Here is a smaller patch. > > H.J., > The smaller patch also solves the bootstrap failure on i386-apple-darwin10. > Jack >
Please ignore the smaller patch since preprocessor may handle TARGET_64BIT_DEFAULT properly. -- H.J.